Skip to content

Support for property hooks #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Dec 28, 2024
Merged

Support for property hooks #3746

merged 41 commits into from
Dec 28, 2024

Conversation

ondrejmirtes
Copy link
Member

No description provided.

@ondrejmirtes
Support for #[Deprecated] attribute
6ad22ee
@ondrejmirtes
Detect hooked properties outside of constructor
03cc9bc
@ondrejmirtes
Invoke virtual ClassPropertyNode for hooked promoted properties witho…
25d18f0 
…ut visibility modifier
@ondrejmirtes
Process property hooks
acf6d03 
* They get a new virtual node InPropertyHookNode
* Existing virtual nodes like InFunctionNode or InClassMethodNode are NOT invoked for them
* But rules for FunctionLike node are invoked for property hooks
* `Scope::getFunction()` returns PhpMethodFromParserNodeReflection inside property hooks
@ondrejmirtes
Fix PHPDocs with generics in property hooks
6f95825
@ondrejmirtes
Adjust method's ReturnTypeRule for property hooks
a6b230f
@ondrejmirtes
ShortGetPropertyHookReturnTypeRule - level 3
6aa0e44
@ondrejmirtes
Invoke PropertyAssignNode in short set property hook
aeec077
@ondrejmirtes
Set checkUninitializedProperties to false in UnusedPrivatePropertyRul…
ec4035d 
…eTest
@ondrejmirtes
Fix UnusedPrivatePropertyRule in regard to property hooks
df2db6d
@ondrejmirtes ondrejmirtes force-pushed the php-84 branch 3 times, most recently from b0f9756 to 4241019 Compare December 26, 2024 13:36
@ondrejmirtes ondrejmirtes mentioned this pull request Dec 27, 2024
Closed
@ondrejmirtes
Fix MissingReturnRule for property hooks
0d22056
@ondrejmirtes
ExtendedPropertyReflection - methods describing hooked properties
21fbe1e
@ondrejmirtes
Allow wider set hook parameter type when assigning properties outside…
bdf6316 
… of their hooks
@ondrejmirtes
Fix canChangeTypeAfterAssignment
373000a
@ondrejmirtes
Test WritingToReadOnlyPropertiesRule for hooked properties
294ba3e
@ondrejmirtes
Test ReadingWriteOnlyPropertiesRule for hooked properties
69f2815
@ondrejmirtes
Test generics in TypesAssignedToPropertiesRule for hooked properties
81f8ed3
@ondrejmirtes
CleaningParser - clean up property hooks
3d5a204
@ondrejmirtes
Fix ReadOnlyByPhpDocPropertyAssignRule for hooked properties
2da91f8
@ondrejmirtes
Introduce PropertyHookReturnStatementsNode similar to MethodReturnSta…
a9202b0 
…tementsNode
@ondrejmirtes
SetNonVirtualPropertyHookAssignRule - level 3
c72e822
@ondrejmirtes
GetNonVirtualPropertyHookReadRule - level 3
abe0eaa
@ondrejmirtes
Test ReturnNullsafeByRefRule with property hooks
7f6cd04
@ondrejmirtes
Support #[Deprecated] attribute in property hooks
a72355e
@ondrejmirtes
Hooked properties can throw custom exceptions
b81fc37
@ondrejmirtes
TooWidePropertyHookThrowTypeRule - level 4
d858543
@ondrejmirtes
ThrowsVoidPropertyHookWithExplicitThrowPointRule - level 3
ca79b6e
@ondrejmirtes
MissingCheckedExceptionInPropertyHookThrowsRule
f9dad4d
@ondrejmirtes
Adjust InvalidThrowsPhpDocValueRule for property hooks
2450039
@ondrejmirtes
Adjust InvalidPhpDocTagValueRule and InvalidPHPStanDocTagRule for pro…
ffe82b3 
…perty hooks
@ondrejmirtes
Test MatchExpressionRule with property hooks
a57eea5
@ondrejmirtes
Extract IncompatiblePhpDocTypeCheck from IncompatiblePhpDocTypeRule
e28118e
@ondrejmirtes
IncompatiblePropertyHookPhpDocTypeRule - level 2
7f3c340
@ondrejmirtes
ExistingClassesInPropertyHookTypehintsRule - level 0
4030fc1
@ondrejmirtes
Useful getPropertyReflection() shortcut in property hook virtual nodes
7f51614
@ondrejmirtes
ExtendedParameterReflection::hasNativeType()
97710e6
@ondrejmirtes
SetPropertyHookParameterRule - level 0 and 3
2f6808a
@ondrejmirtes
Report missing types in SetPropertyHookParameterRule - level 6
85e0c1f
@ondrejmirtes ondrejmirtes changed the title Support for PHP 8.4 Support for property hooks Dec 28, 2024
@ondrejmirtes ondrejmirtes marked this pull request as ready for review December 28, 2024 14:06
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit 70572a1 into 2.1.x Dec 28, 2024
424 of 427 checks passed
@ondrejmirtes ondrejmirtes deleted the php-84 branch December 28, 2024 14:07
@ondrejmirtes ondrejmirtes mentioned this pull request Dec 29, 2024
Open
34 tasks
@Seb33300 Seb33300 mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ondrejmirtes @phpstan-bot